Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/let user remove custom exchange rate #195

Merged
merged 10 commits into from
Jul 14, 2023
Merged

feat/let user remove custom exchange rate #195

merged 10 commits into from
Jul 14, 2023

Conversation

cripacrip
Copy link
Collaborator

@cripacrip cripacrip commented Jul 11, 2023 •
edited by letehaha
Loading

Closes #175

@cripacrip cripacrip requested a review from letehaha July 11, 2023 12:08
@cypress
Copy link

cypress bot commented Jul 11, 2023 •
edited
Loading

Passing run #96 ↗︎

0 11 1 0 Flakiness 0

Details:

Merge c6d720c into 6d8799b...
Project: budget-tracker Commit: 1faed41cbd ℹ️
Status: Passed Duration: 01:05 💡
Started: Jul 14, 2023 7:33 PM Ended: Jul 14, 2023 7:34 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

letehaha
letehaha requested changes Jul 11, 2023
View reviewed changes
Copy link
Owner

@letehaha letehaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a rebase of the main branch, there're merge conflicts in that branch.

Also, there are a bunch of TSLint issues in that PR that should be fixed.

image

src/api/currencies.ts Outdated Show resolved Hide resolved
src/api/currencies.ts Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/list.vue Outdated Show resolved Hide resolved
@cripacrip cripacrip requested a review from letehaha July 11, 2023 14:33
letehaha
letehaha requested changes Jul 11, 2023
View reviewed changes
Copy link
Owner

@letehaha letehaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turned out eslint wasn't set up correctly. I fixed npm script, now you should be able to see bunch of errors

src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
src/api/currencies.ts Outdated Show resolved Hide resolved
src/pages/settings/tabs/currencies/edit-currency.vue Outdated Show resolved Hide resolved
@cripacrip cripacrip requested a review from letehaha July 12, 2023 15:21
@cripacrip cripacrip force-pushed the feat/let-user-remove-custom-exch-rate branch from 0f239d3 to a7c3dd0 Compare July 13, 2023 07:52
letehaha
letehaha requested changes Jul 13, 2023
View reviewed changes
src/components/fields/input-field.vue Outdated Show resolved Hide resolved
src/components/fields/input-field.vue Outdated Show resolved Hide resolved
@letehaha letehaha added the type::enhancement New feature or request label Jul 14, 2023
@letehaha letehaha self-requested a review July 14, 2023 19:52
@letehaha letehaha merged commit 650e399 into main Jul 14, 2023
@letehaha letehaha deleted the feat/let-user-remove-custom-exch-rate branch July 14, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letehaha letehaha letehaha approved these changes

Assignees

@cripacrip cripacrip

Labels
type::enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Let user remove custom exchange rate
2 participants
@cripacrip @letehaha